fix(hono-base): don't use Symbol for COMPOSED_HANDLER
#3773
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size check
Compiler Diagnostics
Reported by octocov |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3773 +/- ##
========================================
Coverage 91.72% 91.72%
========================================
Files 159 160 +1
Lines 10175 10177 +2
Branches 2991 2882 -109
========================================
+ Hits 9333 9335 +2
Misses 841 841
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Hey @usualoma. Can you review this? |
|
I think merging this without waiting for others to review is OK. If you have any suggestions, feel free to create a PR to resolve them. I'll merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3760
This PR resolves the problem described in #3760. It uses a string value for
COMPOSED_HANDLERinstead of a Symbol. We should add a test for afixchange, but in this PR, it's challenging to reproduce the problem in #3760, so it doesn't include a test.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code